[MM-62241] Fix screen sharing from Calls popout window #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
devinbinnie
approved these changes
Dec 16, 2024
cpoile
approved these changes
Dec 17, 2024
| @@ -362,6 +362,12 @@ describe('main/windows/callsWidgetWindow', () => { | |||
| urlUtils.isCallsPopOutURL.mockReturnValue(false); | |||
| expect(callsWidgetWindow.onPopOutOpen({url: 'http://localhost:8065/notpopouturl'})).toHaveProperty('action', 'deny'); | |||
| }); | |||
|
|
|||
| it('should pop out and make sure preload is set', () => { | |||
|
@DHaussermann You should be familiar with this since you hit it before while testing unrelated changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As of #3174, some of the functionality in the Calls popout window (e.g. screen sharing) stopped working since
desktopAPIis missing on the window object. Using the local preload seems to be the way to go.Since we are here, I am also adding an extra dynamic menu item to access the developer tools of the popout, which can be helpful in debugging future issues like this one.
/cc @matthewbirtch
Ticket Link
https://mattermost.atlassian.net/browse/MM-62241
Release Note